Add set_scheme_unchecked as a new Url method.#1073
Open
moonheart08 wants to merge 2 commits intoservo:mainfrom
Open
Add set_scheme_unchecked as a new Url method.#1073moonheart08 wants to merge 2 commits intoservo:mainfrom
moonheart08 wants to merge 2 commits intoservo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you have a custom scheme that is compatible with the special schemes,
set_schemewill reject it, and there is no API to do the scheme set and fixup yourself.This is motivated by RobustToolbox's
ss14/ss14sprotocols, which are just http/https (not HTTP3) with the guarantee a game server is running on the UDP port.Prior to this PR, the only way to construct an
httpURL from a validss14scheme is to create the new URL yourself with strings, which is unnecessarily cumbersome.Technical changes
Only extracting the scheme setting portion of
set_schemeintoset_scheme_internal.